Code reviews
Lately I’ve been doing a lot of work on the DOM Inspector, mostly improving the UI and making things work as I would expect them to work. I’m grateful for the domi peers who review patches fairly quickly. I still feel the review system is mostly broken - why should I have to pester people over IRC to review my patches? Why do I have to ask around just to find out which peers ever do reviews? When a patch is ignored, it doesn’t just affect that patch: it makes the writer feel unappreciated and less likely to continue writing patches. Slow or non-existant reviews are what stops me from working on Firefox itself.
I understand that people are busy doing other things, but couldn’t there a way to ask for a review from any Component X peer, and so those who actually are doing reviews can respond in a timely manner?
May 29th, 2006 at 3:07 pm
Its always good to see new patches for the DOM inspector in Peter(6)’s build threads, too bad none of them are for branch right now. What would be awesome is if the DOMi with the new changes could be downloaded as an .xpi.
I agree there needs to be a list of people who do code reviews, so patches can get checked in faster. It sucks that some parts of bugzilla are so unorganized.
May 29th, 2006 at 4:59 pm
The plan is to get DOMi onto AMO so branch/trunk stuff won’t matter.
May 29th, 2006 at 5:34 pm
Cool. Voted.
June 19th, 2006 at 4:50 am
Actually, you can download/install DOMi from ftp.mozilla.org/firefox/[releases|nightly]/ ……… /adt.xpi
But I agree, it should be on AMO